Skip to content

Expose RevokedCertificate Rust class directly #13837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Expose RevokedCertificate Rust class directly #13837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/cryptography/hazmat/bindings/_rust/x509.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,15 @@ class Certificate:
def public_bytes(self, encoding: serialization.Encoding) -> bytes: ...
def verify_directly_issued_by(self, issuer: Certificate) -> None: ...

class RevokedCertificate: ...
class RevokedCertificate:
@property
def serial_number(self) -> int: ...
@property
def revocation_date(self) -> datetime.datetime: ...
@property
def revocation_date_utc(self) -> datetime.datetime: ...
@property
def extensions(self) -> x509.Extensions: ...

class CertificateRevocationList:
def public_bytes(self, encoding: serialization.Encoding) -> bytes: ...
Expand Down
38 changes: 1 addition & 37 deletions src/cryptography/x509/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

from __future__ import annotations

import abc
import datetime
import os
import typing
Expand All @@ -29,7 +28,6 @@
)
from cryptography.x509.extensions import (
Extension,
Extensions,
ExtensionType,
_make_sequence_methods,
)
Expand Down Expand Up @@ -160,41 +158,7 @@ def __init__(self, msg: str, parsed_version: int) -> None:


Certificate = rust_x509.Certificate


class RevokedCertificate(metaclass=abc.ABCMeta):
@property
@abc.abstractmethod
def serial_number(self) -> int:
"""
Returns the serial number of the revoked certificate.
"""

@property
@abc.abstractmethod
def revocation_date(self) -> datetime.datetime:
"""
Returns the date of when this certificate was revoked.
"""

@property
@abc.abstractmethod
def revocation_date_utc(self) -> datetime.datetime:
"""
Returns the date of when this certificate was revoked as a non-naive
UTC datetime.
"""

@property
@abc.abstractmethod
def extensions(self) -> Extensions:
"""
Returns an Extensions object containing a list of Revoked extensions.
"""


# Runtime isinstance checks need this since the rust class is not a subclass.
RevokedCertificate.register(rust_x509.RevokedCertificate)
RevokedCertificate = rust_x509.RevokedCertificate


CertificateRevocationList = rust_x509.CertificateRevocationList
Expand Down