Skip to content

notice_numbers are not optional in NoticeReference #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2015
Merged

notice_numbers are not optional in NoticeReference #1936

merged 2 commits into from
May 13, 2015

Conversation

reaperhulk
Copy link
Member

I misread the RFC. Here's the definition:

NoticeReference ::= SEQUENCE {
     organization     DisplayText,
     noticeNumbers    SEQUENCE OF INTEGER }

Note the lack of "OPTIONAL".

refs #1743

@reaperhulk reaperhulk added this to the Ninth Release milestone May 12, 2015
@alex
Copy link
Member

alex commented May 13, 2015

lgtm please rebase for coverage

alex added a commit that referenced this pull request May 13, 2015
@alex
Merge pull request #1936 from reaperhulk/cp-noticenumbers-required
0facc2a 
notice_numbers are not optional in NoticeReference
@alex alex merged commit 0facc2a into pyca:master May 13, 2015
@reaperhulk reaperhulk deleted the cp-noticenumbers-required branch May 13, 2015 14:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bugs x509

Milestone

Ninth Release

Development

Successfully merging this pull request may close these issues.

2 participants

@reaperhulk @alex