Implement Connection.recv_into

[exarkun]

No description provided.

[alex]

FWIW with cffi 0.9 the the ffi.from_buffer method would let you skip this allocation

[exarkun]

Looks like only in some cases. Not if the given buffer is a bytearray, for example?

[alex]

Yes, I believe that's correct.

On Sun, Mar 15, 2015 at 6:05 PM, Jean-Paul Calderone <
notifications@github.com> wrote:

In OpenSSL/SSL.py
#199 (comment):

•        buffer. If not present, defaults to the size of the buffer. If
  

•        larger than the size of the buffer, is reduced to the size of the
  

•        buffer.
  

•    :param flags: (optional) Included for compatibility with the socket
  

•        API, the value is ignored.
  

•    :return: The number of bytes read into the buffer.
  

•    """
  

•    if nbytes is None:
  

•        nbytes = len(buffer)
  

•    else:
  

•        nbytes = min(nbytes, len(buffer))
  

•    # We need to create a temporary buffer. This is annoying, it would be
  

•    # better if we could pass memoryviews straight into the SSL_read call,
  

•    # but right now we can't. Revisit this if CFFI gets that ability.
  

•    buf = _ffi.new("char[]", nbytes)
  

Looks like only in some cases. Not if the given buffer is a bytearray,
for example?

—
Reply to this email directly or view it on GitHub
https://github.com/pyca/pyopenssl/pull/199/files#r26453014.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

[coveralls]

Coverage decreased (-0.08%) to 94.52% when pulling dfe9e49 on exarkun:recv_into into b819738 on pyca:master.

[coveralls]

Coverage decreased (-0.08%) to 94.52% when pulling dfe9e49 on exarkun:recv_into into b819738 on pyca:master.

[coveralls]

Coverage decreased (-0.08%) to 94.52% when pulling 0191a18 on exarkun:recv_into into b819738 on pyca:master.