Allow for using the raw OpenSSL verify callback #257
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyOpenSSL has the ability to set the verify callback, but it tries to be all 'helpful' and 'user friendly' and all that hippy crap, so it hides the terrible OpenSSL nonsense from me.
Sadly, for urllib3/urllib3#607 I need access to the X509_STORE_CTX that PyOpenSSL is hiding. This patch allows me to set a different verify callback that does that.
This is only a proposed API, I'm not wedded to it at all, so feedback on the API and naming is totally welcomed.