Skip to content

Conversation

@ffyuanda
Copy link
Member

@ffyuanda ffyuanda commented Jun 16, 2021

Fix: #9

@ffyuanda

This comment has been minimized.

@ffyuanda
Copy link
Member Author

ffyuanda commented Jun 16, 2021

@hsluoyz @techoner @Zxilly plz review

@ffyuanda ffyuanda marked this pull request as ready for review June 16, 2021 01:08
@Zxilly
Copy link

Zxilly commented Jun 16, 2021

Could you please use semantic release?

@ffyuanda ffyuanda marked this pull request as draft June 16, 2021 01:44
@ffyuanda ffyuanda marked this pull request as ready for review June 16, 2021 03:31
@ffyuanda
Copy link
Member Author

@Zxilly plz review

@Zxilly
Copy link

Zxilly commented Jun 16, 2021

@ffyuanda semantic-release-pypi has some specific behaviors. plz refer to: pycasbin/flask-authz#31, pycasbin/flask-authz#30

@ffyuanda
Copy link
Member Author

@Zxilly just removed the version in setup.py, this might resolve the no-release-on-pypi issue?

@Zxilly
Copy link

Zxilly commented Jun 16, 2021

@ffyuanda also import __version__ from setuptools, and add setup.cfg

@hsluoyz hsluoyz requested review from Zxilly and leeqvip June 16, 2021 05:28
@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

@ffyuanda squash into 1 commit

Signed-off-by: ffyuanda <46557895+ffyuanda@users.noreply.github.com>
@leeqvip leeqvip merged commit 9297043 into pycasbin:master Jun 16, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change travis-ci to github-action .

4 participants