Clean up installation procedure with pip #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: psydac now provides version to user: In [1]: import psydac; psydac.__version__ Out[1]: '0.1'
In addition, if 'EvalQuadratureMapping' is called on a vector function space of 'undefined' kind, we create a temporary scalar function space of 'H1' kind and assume that all vector components belong to this space.
ratnania
reviewed
Oct 29, 2019
Collaborator
ratnania
left a comment
ratnania
left a comment
There was a problem hiding this comment.
some changes may be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to drastically simplify the installation procedure using pip, which now downloads all dependencies from PyPI (with the notable exception of
h5pyandigakit). Further, all deprecation warnings have been removed, and the source code passes Codacy's quality review (hence, this pull request solves #52).