Merged
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
add Pytest mark @pytest.mark.xdist_group('h5py') to all unit tests in
psydac/api/tests/test_postprocessing.py because h5py is not thread-safe.
kvrigor
approved these changes
Mar 25, 2026
campospinto
approved these changes
Mar 25, 2026
Collaborator
campospinto
left a comment
There was a problem hiding this comment.
This PR has a lot of improvements, thanks ! I can only do a shallow review but it seems good to me. I just have one question mostly to clarify a point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyccel >= 2.2.3: this allows compiling all kernels with Ch5py >= 3.16to allow for standard install withsetuptools >= 81.0numpy >= 2.1to support Python >= 3.10pytest.tomlinstead ofpytest.inifor Pytest configuration (requirespytest >= 9.0)pyproject.tomltopsydac/pytest.tomlpytest-xdistbecauseh5pyis not thread-safe: add Pytest mark@pytest.mark.xdist_group('h5py')to all unit tests inpsydac/api/tests/test_postprocessing.pypsydac testcommand; this was not correctly returned before, hence the CI could not detect when the unit tests were failing in a subprocesspsydac compilecommand; this fix does not directly affect the CI, but it is included for correctness.psydac testcommand in CI testingpytest->scratch.gitignore; specifically, stop ignoring files which don't exist anymore