Add documentation of MDNS #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilycey
approved these changes
Dec 12, 2019
Contributor
lilycey
left a comment
lilycey
left a comment
There was a problem hiding this comment.
All good bar one small question!
|
|
||
| The arguments are: | ||
|
|
||
| * `service_type` is the type of the offered service, e.g.: _http, _ftp or can be custom service |
Contributor
There was a problem hiding this comment.
The formatting here seems slightly different - will it upload well?
Contributor
Author
There was a problem hiding this comment.
I checked and the content of the mdns.md is exactly the same as what we have on the publish-development branch. Is that a problem?
Contributor
|
If this is the stable firmware feature, we should open the second PR and merge this branch also to development-publish I wrote a script which can open two PRs automatically and assign a reviewer to it here |
Contributor
Author
|
The documentation of this feature has already been merged into development-publish: #183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDNS feature is released with PR: pycom/pycom-micropython-sigfox#377
Adding documentation for it.