This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Endable a debug mode for modlte.c #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various debug messages were commented out in modlte.c. Instead of commenting them out, they are now only active if LTE_DEBUG is set to 1.
|
Hi @brotherdust it would actually be useful to have a reasonable debug mode! However, as of now (much to our own delay :( ) this conflicts a lot. Frankly it would need a rewrite. Including deciding a reasonable set of messages because many of these printf aren't even there anymore I close this, since it needs a rewrite anyway. If you are still interested in this topic please make a new PR and feel free to ping me. Some nitpicking:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various useful debug messages that are commented out in modlte.c. I put each of them in a macro block (I think that's what it's called, correct me if I'm wrong) and un-commented. They can now be activated by setting LTE_DEBUG to 1