narrow _load_plugin exception handler in plugins.finder - #2036
Closed
HrachShah wants to merge 1 commit into
Closed
Conversation
…not-found/value errors that importlib.metadata.EntryPoint.load() can actually raise
Member
|
an import can raise an arbitrary exception so first no. also this llm is bad and assumes KeyboardInterrupt and SystemExit subclasss Exception 😆 please actually do your own work next time instead of throwing slop over the fence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_load_plugin in src/flake8/plugins/finder.py catches bare 'except Exception as e' around plugin.entry_point.load() and rewraps the error as a FailedToLoadPlugin. The narrow set of failures that importlib.metadata.EntryPoint.load() can actually raise is:
Other Exception subclasses (e.g. OSError, TypeError, RuntimeError, KeyError, IndexError) are not on this path: OSError would indicate a flake8 host bug (e.g. permissions on the wheel cache), and TypeError/KeyError/IndexError are programming bugs in importlib that already raise from the resolver as one of the four above. Listing the specific exception types makes the catch self-documenting and lets KeyboardInterrupt/SystemExit propagate to the asyncio/multiprocessing pool machinery that owns the future, rather than being silently converted into a 'failed to load plugin' report that hides the user's Ctrl-C.