Handle nulls first/last #11
Merged
+137
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suibianwanwank
commented
Mar 24, 2025
|
|
||
| // TODO: handle nulls first/last? | ||
| filters.push(comparison); | ||
| let predicate = if threshold.sort_options.nulls_first { |
Author
There was a problem hiding this comment.
Also, I have some questions about this logic. Does it handle ordering by multiple column correctly?
Member
There was a problem hiding this comment.
Worth adding a test! I think we'll want a black box test that checks that results with and without this feature are the same.
suibianwanwank
commented
Mar 24, 2025
Author
suibianwanwank
left a comment
suibianwanwank
left a comment
There was a problem hiding this comment.
Hi, @adriangb Sorry for the delay, things got a bit busy on my end. If you have time, feel free to check out this PR~
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_topk_predicate_pushdown_nulls_fist() { |
Author
There was a problem hiding this comment.
Two tests have been added here. Perhaps we could merge some of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few tweaks to the transforms commented on PR.