Fix multiple columns sort #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Mar 26, 2025
Member
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
Nice this looks great, thanks so much for pushing this forward!
Let's merge this and keep on iterating. I think the test that's going to be super valuable here is a fuzz like test that tests multiple combinations of columns, orders, types, number of partitions, etc. and compares the results with and without the dynamic pushdown feature flag enabled since the end results should always match.
Author
|
Thanks! 100% agree — this is a great next step. |
adriangb
pushed a commit
that referenced
this pull request
Mar 27, 2025
adriangb
pushed a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adriangb I added several tests related to multiple columns and found that the current implementation returns incorrect results.
I've made some fixes and attempted to streamline the test code. However, it seems there may still be room for further optimization. Could you please review the changes. :)