Skip to content

Bump sync_stream_write benchmark payload to 64MB#957

Merged
Kludex merged 1 commit into
mainfrom
bump-bench-payload-64mb
May 17, 2026
Merged

Bump sync_stream_write benchmark payload to 64MB#957
Kludex merged 1 commit into
mainfrom
bump-bench-payload-64mb

Conversation

@Kludex
Copy link
Copy Markdown
Member

@Kludex Kludex commented May 17, 2026

Summary

  • The 4MB payload in test_bench_sync_stream_write_large wasn't forcing enough partial sends on the CodSpeed Macro Runner to expose the buffer-slicing cost that perf: use memoryview in write() to avoid copies #954 optimizes.
  • Bumping to 64MB guarantees many partial-send iterations regardless of how the kernel sizes SO_SNDBUF, which is the path the memoryview optimization targets.

Test plan

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 17, 2026

Merging this PR will degrade performance by 95.27%

❌ 1 regressed benchmark
✅ 6 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_bench_sync_stream_write_large 11.5 ms 243.1 ms -95.27%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bump-bench-payload-64mb (1ab0bb9) with main (4fecf95)

Open in CodSpeed

@Kludex Kludex merged commit 8d5f182 into main May 17, 2026
12 of 13 checks passed
@Kludex Kludex deleted the bump-bench-payload-64mb branch May 17, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant