Skip to content

Deploy docs to GitHub Pages and Cloudflare Workers#993

Merged
Kludex merged 4 commits into
mainfrom
deploy-docs-to-cloudflare-workers
May 29, 2026
Merged

Deploy docs to GitHub Pages and Cloudflare Workers#993
Kludex merged 4 commits into
mainfrom
deploy-docs-to-cloudflare-workers

Conversation

@Kludex
Copy link
Copy Markdown
Member

@Kludex Kludex commented May 29, 2026

Sets up docs deployment for httpx2, matching the Starlette setup.

  • publish.yml: the build job now also builds the docs and uploads a documentation artifact; new docs-publish (GitHub Pages) and docs-cloudflare (Workers deploy) jobs publish it on tag releases.
  • main.yml: new docs-cloudflare-preview job uploads a versioned preview per PR and comments the URL.
  • wrangler.toml: replaces docs-site/ with a root config (Starlette structure), keeping the httpx2-docs worker name and the httpx2.pydantic.dev custom domain.
  • scripts/build: build with a clean cache (-c) so objects.inv is regenerated populated - zensical's incremental cache was emitting an empty inventory.

Requires the cloudflare and github-pages environments plus the CLOUDFLARE_API_TOKEN / CLOUDFLARE_ACCOUNT_ID secrets to be configured on the repo.

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

Kludex added 2 commits May 29, 2026 07:00
Add CI to publish the docs on tag releases (GitHub Pages and Cloudflare
Workers Static Assets) plus Cloudflare PR previews, matching the Starlette
setup. Move the Cloudflare config to a root wrangler.toml and drop the
docs-site directory. Build docs with a clean cache so objects.inv is
populated.
The previous commit landed only the config move; this adds the GitHub
Pages and Cloudflare Workers deploy jobs, the PR preview job, the
documentation artifact build, the .wrangler ignore, and the clean docs
build.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will not alter performance

✅ 15 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing deploy-docs-to-cloudflare-workers (b11ba10) with main (c2a2b8d)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59a32cff0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wrangler.toml
@@ -0,0 +1,10 @@
name = "httpx2-docs"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire the docs deployment into the workflows

This adds the root Worker config, but the checked workflow files still never build or deploy the docs: .github/workflows/publish.yml still only runs uv build --all-packages and uploads package-distributions, while a repo-wide search for wrangler, documentation, and docs-cloudflare only finds this config. On tag releases the new Cloudflare/Pages setup is therefore unused, so docs will not be published unless the missing publish/preview jobs are added or another deploy path is restored.

Useful? React with 👍 / 👎.

@pydantic pydantic deleted a comment from github-actions Bot May 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

@Kludex Kludex deployed to cloudflare May 29, 2026 07:03 — with GitHub Actions Active
@Kludex Kludex merged commit fee387a into main May 29, 2026
14 checks passed
@Kludex Kludex deleted the deploy-docs-to-cloudflare-workers branch May 29, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant