Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
397915f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20fb1a9d.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-langsmith-provider.logfire-docs.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| elif actual_system == 'langchain': | ||
| system = attributes.get('gen_ai.system') | ||
| if system in (None, 'langchain'): | ||
| system = attributes.get('langsmith.metadata.ls_provider') or guess_system(request_model) |
Contributor
There was a problem hiding this comment.
🚩 No test coverage for langsmith.metadata.ls_provider attribute
The new langsmith.metadata.ls_provider extraction at line 403 is the main feature of this PR, but none of the test cases in test_claude_sdk.py or test_langchain.py include this attribute in their input data. All existing tests exercise the guess_system(request_model) fallback path or the case where gen_ai.system is already valid. A test with langsmith.metadata.ls_provider set (and gen_ai.system as None or 'langchain') would confirm the primary new behavior works end-to-end.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.