Skip to content

Drop support for Python < 3.9.2#1920

Merged
alexmojaki merged 5 commits into
mainfrom
codex/py39-compatible-cleanups
May 12, 2026
Merged

Drop support for Python < 3.9.2#1920
alexmojaki merged 5 commits into
mainfrom
codex/py39-compatible-cleanups

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

@alexmojaki alexmojaki commented May 11, 2026

Moving towards dropping 3.9 entirely in #1919

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 11, 2026

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 536d947
Status: ✅  Deploy successful!
Preview URL: https://11e0ea54.logfire-docs.pages.dev
Branch Preview URL: https://codex-py39-compatible-cleanu.logfire-docs.pages.dev

View logs

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Comment thread tests/otel_integrations/test_claude_sdk.py
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="pyproject.toml">

<violation number="1" location="pyproject.toml:9">
P2: This change narrows supported Python versions to 3.9.2+ and may unintentionally block users on Python 3.9.0/3.9.1. If the goal is still general Python 3.9 support, keep the floor at `>=3.9`.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Comment thread pyproject.toml
@alexmojaki
Copy link
Copy Markdown
Collaborator Author

(AI) Intentional. Python 3.9.0/3.9.1 have a broken collections.abc.Callable generic implementation that can fail in runtime typing contexts and also reports misleading line events for this branch. This PR keeps Python 3.9 support but makes the declared floor >=3.9.2, where that behavior is fixed.

@alexmojaki alexmojaki changed the title Add py39-compatible cleanup coverage Drop support for Python < 3.9.2 May 12, 2026
@alexmojaki alexmojaki merged commit 675025d into main May 12, 2026
18 checks passed
@alexmojaki alexmojaki deleted the codex/py39-compatible-cleanups branch May 12, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant