Skip to content

Remove Python 3.9 handlebars test skips#1955

Merged
alexmojaki merged 1 commit into
feature/variable-composition-cleanfrom
codex/remove-py39-variable-composition
May 22, 2026
Merged

Remove Python 3.9 handlebars test skips#1955
alexmojaki merged 1 commit into
feature/variable-composition-cleanfrom
codex/remove-py39-variable-composition

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

Summary

  • remove Python 3.9-era pydantic-handlebars skip wrappers from the managed variable tests
  • remove Python-version-specific docs and optional dependency error wording for template variables
  • keep the optional-extra error path because pydantic-handlebars is still provided by logfire[variables], not the core install

Tests

  • uv run pytest tests/test_variable_templates.py tests/test_template_validation.py tests/test_variable_composition.py tests/test_docs.py -q
  • uv run ruff check logfire/variables/_handlebars.py tests/test_docs.py tests/test_template_validation.py tests/test_variable_composition.py tests/test_variable_templates.py
  • uv run pyright logfire/variables/_handlebars.py tests/test_docs.py tests/test_template_validation.py tests/test_variable_composition.py tests/test_variable_templates.py

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@alexmojaki alexmojaki merged commit be9cd1f into feature/variable-composition-clean May 22, 2026
17 checks passed
@alexmojaki alexmojaki deleted the codex/remove-py39-variable-composition branch May 22, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant