Skip to content

Add db.query.text to scrubber SAFE_KEYS#1959

Merged
alexmojaki merged 1 commit into
pydantic:mainfrom
bendrucker:scrubber-db-query-text
May 22, 2026
Merged

Add db.query.text to scrubber SAFE_KEYS#1959
alexmojaki merged 1 commit into
pydantic:mainfrom
bendrucker:scrubber-db-query-text

Conversation

@bendrucker
Copy link
Copy Markdown
Contributor

@bendrucker bendrucker commented May 22, 2026

Adds 'db.query.text' to BaseScrubber.SAFE_KEYS alongside the deprecated 'db.statement'.

Upstream OTel semconv replaced db.statement with db.query.text Until the scrubber's allow list tracks the new name, anyone emitting db.query.text loses SQL text to scrubbing whenever a query contains trigger tokens like privateKey, password, or secret.

'db.statement' is kept for backwards compatibility .

See the OTel SQL semconv for the current canonical attribute names.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@alexmojaki alexmojaki merged commit 8d7d63e into pydantic:main May 22, 2026
16 checks passed
@alexmojaki
Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants