Skip to content

Conversation

@medaminezghal
Copy link
Contributor

Those optional dependencies comes from those files in this folder:
1- MCP
2- OpenAI agents
3- PydanticAI

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@medaminezghal
Copy link
Contributor Author

If openai-agents<0.09 the tests will fails

@alexmojaki
Copy link
Contributor

There's no need for this. pip install logfire[fastapi] is useful because it installs opentelemetry-instrumentation-fastapi which is required for instrument_fastapi to work. It doesn't also install fastapi because it's implied that the user has that or they wouldn't need to call instrument_fastapi. We don't need to tell a user to pip install mcp or logfire[mcp] to use instrument_mcp, it's redundant.

The versions don't need to be regularly updated in pyproject.toml, uv.lock takes care of that.

@alexmojaki alexmojaki closed this Apr 11, 2025
@medaminezghal medaminezghal deleted the update-opt-dependencies branch April 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants