Add custom reasoning field support to OpenAI model profiles #3536
+185
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Author
This test is interesting: we are getting different line breaks by spilting thinks and texts and recombining them again (which the code does originally). I don't think it's good for context caching, but let's keep it for now.
|
- Introduced `openai_chat_custom_reasoning_field` and `openai_chat_include_reasoning_in_request` to `OpenAIModelProfile`. - Updated `deepseek_model_profile` and `moonshotai_model_profile` to utilize the new fields. - Enhanced `OpenAIChatModel` to prefer custom reasoning fields and provide fallback options. - Added relevant documentations.
ZeroAurora
force-pushed
the
feat/custom-reasoning-field
branch
from
ac74841 to
31b3042
Compare
Author
|
all pass full cov let's goooo |
DouweM
requested changes
Nov 26, 2025
Author
|
Let me start work on this |
This comment was marked as resolved.
This comment was marked as resolved.
ZeroAurora
force-pushed
the
feat/custom-reasoning-field
branch
from
2a249d5 to
c37a657
Compare
ZeroAurora
force-pushed
the
feat/custom-reasoning-field
branch
from
c37a657 to
1807d54
Compare
ZeroAurora
force-pushed
the
feat/custom-reasoning-field
branch
from
1807d54 to
c93aa15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3446 . Related to #3515.
#3533 is doing the same.
openai_chat_custom_reasoning_fieldandopenai_chat_include_reasoning_in_requesttoOpenAIModelProfile.deepseek_model_profileandmoonshotai_model_profileto utilize the new fields.OpenAIChatModelto prefer custom reasoning fields and provide fallback options.