Skip to content

MNT: remove setup.cfg#493

Merged
neutrinoceros merged 3 commits intopydata:masterfrom
neutrinoceros:mnt/drop-setup.cfg
Jan 19, 2026
Merged

MNT: remove setup.cfg#493
neutrinoceros merged 3 commits intopydata:masterfrom
neutrinoceros:mnt/drop-setup.cfg

Conversation

@neutrinoceros
Copy link
Collaborator

  • MNT: move versioneer configuration to pyproject.toml
  • CLN: drop unused pytest configuration from setup.cfg
  • MNT: rename setup.cfg -> .flake8

@neutrinoceros neutrinoceros added the packaging Issues related to installing or building bottleneck label Dec 10, 2025
@neutrinoceros neutrinoceros changed the title MNT: remove \setup.cfg\" MNT: remove setup.cfg Dec 10, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review December 10, 2025 12:05
@rgommers
Copy link
Collaborator

Why is the pytest config unused? A quick skim of the docs says it's picked up: https://docs.pytest.org/en/7.1.x/reference/customize.html#setup-cfg

I'd put it in pytest.ini normally, but it does seem to be doing something.

@rdbisme
Copy link
Collaborator

rdbisme commented Dec 11, 2025

Maybe we want to decide if we want all things possile into pyproject.toml or in separate files. I'm more to go all in pyproject.toml (and move from flake8 to ruff)

@neutrinoceros
Copy link
Collaborator Author

Pytest doesn't compose configuration. pyproject.toml takes precedence over setup.cfg, so it's effectively ignored.

@neutrinoceros
Copy link
Collaborator Author

and move from flake8 to ruff

Happy to contribute this too in another PR

Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the small merge conflict. +1 for flake8 -> ruff as well

@rgommers
Copy link
Collaborator

I'm new that web editor thingy, but this merge conflict seemed easy to resolve so I gave it a try.

@rgommers
Copy link
Collaborator

CI is unhappy, not related to this PR:

   Download from "https://github.com/actions/python-versions/releases/download/3.14.2-20014991423/python-3.14.2-win32-arm64-freethreaded.zip"
  Extract downloaded archive
  "C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.ZipFile } catch { } ; try { [System.IO.Compression.ZipFile]::ExtractToDirectory('C:\a\_temp\python-3.14.2-win32-arm64-freethreaded.zip', 'C:\a\_temp\2cd38d63-d0ad-42ab-ab33-b8896d01cda4', $true) } catch { if (($_.Exception.GetType().FullName -eq 'System.Management.Automation.MethodException') -or ($_.Exception.GetType().FullName -eq 'System.Management.Automation.RuntimeException') ){ Expand-Archive -LiteralPath 'C:\a\_temp\python-3.14.2-win32-arm64-freethreaded.zip' -DestinationPath 'C:\a\_temp\2cd38d63-d0ad-42ab-ab33-b8896d01cda4' -Force } else { throw $_ } } ;"
  Execute installation script
  Check if Python hostedtoolcache folder exist...
  Check if current Python version is installed...
  No Python3.14.* found
  Remove registry entries for Python 3.14(arm64-freethreaded)...
  Create Python 3.14.2 folder in C:\hostedtoolcache\windows\Python
  Copy Python binaries to C:\hostedtoolcache\windows\Python\3.14.2\arm64-freethreaded
  Install Python 3.14.2 in C:\hostedtoolcache\windows\Python...
  Error: Remove-Item : Cannot find path 'C:\hostedtoolcache\windows\Python\3.14.2\arm64-freethreaded\python.exe' because it 
  does not exist.

I'll see if I can resolve that.

@neutrinoceros
Copy link
Collaborator Author

@rgommers thanks for trying ! I'll rebase this for a cleaner history, and will also bake your comment about tomllib into metadata so we can't loose track of it !

@neutrinoceros neutrinoceros force-pushed the mnt/drop-setup.cfg branch 2 times, most recently from 1f25f32 to a0cb50c Compare January 19, 2026 15:44
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, time to get this in!

@neutrinoceros neutrinoceros merged commit b209f53 into pydata:master Jan 19, 2026
33 of 35 checks passed
@neutrinoceros neutrinoceros deleted the mnt/drop-setup.cfg branch January 19, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packaging Issues related to installing or building bottleneck

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants