Skip to content

Conversation

@jayvn
Copy link

@jayvn jayvn commented Jan 30, 2020

Fixes crash when reading Fama-French data (US Momentum data specifically)

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #749 into master will decrease coverage by 14.66%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #749       +/-   ##
===========================================
- Coverage   83.77%   69.11%   -14.67%     
===========================================
  Files          62       62               
  Lines        2768     2768               
  Branches      305      305               
===========================================
- Hits         2319     1913      -406     
- Misses        374      776      +402     
- Partials       75       79        +4
Impacted Files Coverage Δ
pandas_datareader/famafrench.py 96.15% <100%> (ø) ⬆️
pandas_datareader/av/forex.py 22.72% <0%> (-72.73%) ⬇️
pandas_datareader/av/quotes.py 26.47% <0%> (-64.71%) ⬇️
pandas_datareader/quandl.py 29.26% <0%> (-63.42%) ⬇️
pandas_datareader/av/time_series.py 32.43% <0%> (-62.17%) ⬇️
pandas_datareader/enigma.py 23.63% <0%> (-60%) ⬇️
pandas_datareader/tiingo.py 38.29% <0%> (-57.45%) ⬇️
pandas_datareader/tests/test_quandl.py 42.59% <0%> (-57.41%) ⬇️
pandas_datareader/oecd.py 43.47% <0%> (-52.18%) ⬇️
pandas_datareader/tests/av/test_av_time_series.py 28.4% <0%> (-51.14%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57766a5...098bcef. Read the comment docs.

@jayvn jayvn closed this Jan 30, 2020
@bashtage
Copy link
Contributor

Was this a temporary issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants