Skip to content

Conversation

@mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Nov 26, 2025

A small update to our Finch notebook to match latest version that we benchmarked against.

@mtsokol mtsokol requested a review from hameerabbasi November 26, 2025 16:26
@hameerabbasi hameerabbasi enabled auto-merge (squash) November 26, 2025 16:36
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #911 will improve performances by ×82

Comparing ms/update-notebook (55aa04f) with main (39abfde)

Summary

⚡ 1 improvement
✅ 339 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
test_elemwise[add-side=500-Finch] 70,332.3 µs 857.7 µs ×82

@mtsokol mtsokol disabled auto-merge November 26, 2025 20:37
@mtsokol mtsokol enabled auto-merge (squash) November 26, 2025 20:37
@mtsokol
Copy link
Collaborator Author

mtsokol commented Nov 26, 2025

@hameerabbasi I think we need to merge it manually

@mtsokol mtsokol merged commit bafe376 into main Nov 27, 2025
26 of 30 checks passed
@mtsokol mtsokol deleted the ms/update-notebook branch November 27, 2025 13:08
@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Nov 27, 2025

Seems like the Windows job just needed a rerun -- no need to force-merge. Thanks for the PR, @mtsokol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants