Skip to content

include max value in pcolormesh output when levels are requested #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+6 −2
Open

include max value in pcolormesh output when levels are requested #10954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a32bd7d
increase last value of levels
Nov 28, 2025
eba3a83
change test to adapt to new situation
Nov 28, 2025
9d2227c
better change of tets
Nov 28, 2025
43f8c6f
rm added line
Nov 28, 2025
9ce536f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions xarray/plot/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ def _determine_cmap_params(
levels = ticker.tick_values(vmin, vmax)
vmin, vmax = levels[0], levels[-1]

# GH10911
if calc_data.max() >= levels[-1]:
levels[-1] = np.nextafter(levels[-1], np.inf)

# GH3734
if vmin == vmax:
vmin, vmax = mpl.ticker.LinearLocator(2).tick_values(vmin, vmax)
Expand Down
4 changes: 2 additions & 2 deletions xarray/tests/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,8 +1209,8 @@ def test_discrete_colormap_list_of_levels(self) -> None:
]:
for kind in ["imshow", "pcolormesh", "contourf", "contour"]:
primitive = getattr(self.darray.plot, kind)(levels=levels)
assert_array_equal(levels, primitive.norm.boundaries)
assert max(levels) == primitive.norm.vmax
np.testing.assert_array_almost_equal(levels, primitive.norm.boundaries)
assert max(levels) <= primitive.norm.vmax
assert min(levels) == primitive.norm.vmin
if kind != "contour":
assert extend == primitive.cmap.colorbar_extend
Expand Down
Loading