allow triggering the upstream-dev CI if the check is skipped#11184
Merged
allow triggering the upstream-dev CI if the check is skipped#11184
Conversation
github-actions
bot
added
the
Automation
Collaborator
Author
|
This appears to have worked, see https://github.com/pydata/xarray/actions/runs/22229189964/job/64303881012 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11096 inadvertently skipped CI if the
detect-ci-triggerjob was skipped. By replacing the defaultsuccess()(trueonly if all previous steps reported'success', everything else, including'skipped', will evaluate tofalse) withalways()and comparing against the result of thecache-pixi-lockstep, we can get CI to run onworkflow_dispatchandscheduleevents again.This has caused me to believe we don't have any current issues with upstream, when we actually do have breaking tests, see #11183.
cc @doronbehar