ci: move pandas/scipy stubs to pypi deps#11370
Conversation
|
cc @Illviljan |
|
looks good to me, but why does this resolve >100 tests that are failing on |
Which workflow are you looking at? |
|
the only one that's failing: https://github.com/pydata/xarray/actions/runs/26844047852/job/79159106197?pr=11370 This shows 59 failing tests, compared to 176 in the latest scheduled run on I think the reason for that is that |
Good catch, thanks for noticing that. It turns out the stubs require a released numpy which bumps numpy off the nightly wheels:
It's not possible to have an upstream environment with nightly numpy and typing across the dependency suite. I have therefore split the upstream test run and upstream type checking:
The mypy-upstream uses a released numpy, but I don't see a way around that given the pins. |
|
I was thinking that we'd put all the |
yes, it's messy 😞 Are you alright with the current approach in this PR (not having numpy nightly in the mypy checks)? |
|
I'm fine with it personally so I'll go ahead and merge. I've opened #11371 to keep track of the issue. |
Description
This PR moves the pandas/scipy stubs to pypi deps so that the test-nightly workflow succeeds, as discussed in #11279. With the previous version, mypy in test-nightly floated to >2 and lacked pip in the env , which caused a lot of failures.
Checklist
whats-new.rstapi.rstAI Disclosure