fix(pdfjs): fix pdf viewer url construction#761
Merged
cristianoliveira merged 1 commit intov4-devfrom Jan 7, 2026
Merged
Conversation
This commit changes how the PDF viewer URL is built to avoid double encoding of the file parameter. Detailed Changes: - Implementation: - Changed editor.js to use URL object for constructing viewer URL. - Changed viewer.mjs to decode file parameter before URL parsing.
cdujeu
approved these changes
Jan 7, 2026
Member
cdujeu
left a comment
cdujeu
left a comment
There was a problem hiding this comment.
lgtm - to be retested on ci deployment
osalama7
reviewed
Jan 7, 2026
| file = params.get("file") ?? AppOptions.get("defaultUrl"); | ||
| try { | ||
| file = new URL(decodeURIComponent(file)).href; | ||
| file = new URL(file).href; |
Contributor
There was a problem hiding this comment.
Small suggestion to protect against file names failing in the new URL(file).href statement
if(file.toString().startsWith('http`) {
// construct
}
Or similar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes how the PDF viewer URL is built to avoid double encoding of the file parameter.
Detailed Changes: