Skip to content

realpath.c: fix obsolete syntax warning#3468

Merged
native-api merged 1 commit into
pyenv:masterfrom
native-api:realpath_warning
Jun 3, 2026
Merged

realpath.c: fix obsolete syntax warning#3468
native-api merged 1 commit into
pyenv:masterfrom
native-api:realpath_warning

Conversation

@native-api
Copy link
Copy Markdown
Member

@native-api native-api commented Jun 2, 2026

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)
    • N/A

Description

  • Here are some details about my PR

fixes "warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23"

Tests

  • My PR adds the following unit tests (if any)

Summary by cubic

Update realpath_builtin in src/realpath.c to use a standard C prototype instead of K&R syntax. Removes the “function definition without a prototype” warning and keeps builds compatible with C23, with no behavior change.

Written for commit bf43036. Summary will update on new commits.

Review in cubic

@native-api native-api requested review from a team as code owners June 2, 2026 22:16
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@native-api native-api merged commit c12fd3a into pyenv:master Jun 3, 2026
22 checks passed
@native-api native-api deleted the realpath_warning branch June 3, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant