Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 8, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

chfw and others added 2 commits October 3, 2020 10:58
* ☔ reproduce #12

* release 0.5.0 🥚 🎡

* 🤝 take latest code from setupmobans and release 0.5.1 🥚 🎡, which carries LICENSE file, pyexcel/pyexcel#103

* 🥚 🎡 release 0.5.2. related to pyexcel/pyexcel#105

* ✨ refuse to write value that will not persist. pyexcel/pyexcel-ods#30

* 🔨 sort import list, code format using black, supreme pep 8 formatter. and update moban to use latest moban 0.3.4

* ✨ use pyexcel-io 0.5.10

* 🔥 replace python 2.6 3.3 with python 3.7-dev

* 🥚 🎡 release 0.5.3

* 🔨 minor update

* 🤝 apply common templates from pyexcel mobans. moremoban/moban#348

* 👕 update coding style

* 📰 add missing files

* 📚 pass moban stage

* 🔥 no longer to generate test files

* ✨ respect moban

* 👕 update format.sh

* 🤝 synchronize the organisational meta data

* 🚀 github actions for moban, pypi release and automatically extract contributors

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 🤝 update project meta

* 🤝 update project meta data

* 🎉 new style ods reader

* 🎉 new style ods writer

* 📚 update changelog

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💄 update coding style

* 💚 use pyexcel-io v0.6.0 in test

Co-authored-by: chfw <chfw@users.noreply.github.com>
* 🎉 new style ods reader

* 🎉 new style ods writer

* 📚 update changelog

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💄 update coding style

* 💚 use pyexcel-io v0.6.0 in test

* 🔨 code refactoring

* 🐛 fix typo

* 🔨 code refactoring

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💚 update merge problem

* 💚 update conf.py

* 💚 fix unit test

Co-authored-by: chfw <chfw@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #20 into master will increase coverage by 1.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   97.61%   98.86%   +1.25%     
==========================================
  Files          12       12              
  Lines         670      618      -52     
==========================================
- Hits          654      611      -43     
+ Misses         16        7       -9     
Impacted Files Coverage Δ
pyexcel_ods3/__init__.py 100.00% <100.00%> (ø)
pyexcel_ods3/odsr.py 100.00% <100.00%> (+2.81%) ⬆️
pyexcel_ods3/odsw.py 100.00% <100.00%> (ø)
tests/base.py 98.87% <100.00%> (+1.12%) ⬆️
tests/test_bug_fixes.py 98.61% <100.00%> (+5.35%) ⬆️
tests/test_filter.py 100.00% <100.00%> (ø)
tests/test_multiple_sheets.py 97.75% <100.00%> (+0.51%) ⬆️
tests/test_ods_reader.py 100.00% <100.00%> (ø)
tests/test_writer.py 96.96% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0384838...da7180e. Read the comment docs.

@chfw chfw merged commit 2393904 into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants