Skip to content

Conversation

@PLPeeters
Copy link
Contributor

I had a case where a corrupt XLSX file caused pyexcel to hang forever when reading with iget_records.

This PR contains:

  • A fix for the above
  • General improvements to the regular expressions
  • A migration of the tests to pytest

Ironically, my corrupt XLSX file is read perfectly fine after the changes.

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@PLPeeters
Copy link
Contributor Author

@chfw Any chance you could take a look at this?

@chfw
Copy link
Member

chfw commented Oct 31, 2025

@PLPeeters , do you still need this one? I am sorry to respond late.

@PLPeeters
Copy link
Contributor Author

@chfw No worries, glad to see you're still here :) Still need it yes, I'll rebase on dev.

@PLPeeters PLPeeters force-pushed the bugfix/row-regex-freeze branch from 71acae8 to 17c4373 Compare October 31, 2025 09:17
@PLPeeters PLPeeters force-pushed the bugfix/row-regex-freeze branch from 17c4373 to 8fe1f42 Compare October 31, 2025 09:21
@PLPeeters
Copy link
Contributor Author

@chfw All done, but I do see the autocommit after my other PR re-overwrote the testing command to use nose instead of pytest. Tried to look into it but I'm failing to understand what generates that, so that one is for you :p

@chfw chfw merged commit 1805b3b into pyexcel:dev Oct 31, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants