New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

didn't set sheetname when saving records #126

Closed
goldmonkey163com opened this Issue Mar 21, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@goldmonkey163com

goldmonkey163com commented Mar 21, 2018

import pyexcel
records=pyexcel.get_records(file_name='凭证导入模板.xls')
records.append(records[0])
pyexcel.save_as(records=records,dest_file_name='03211339.xls',dest_sheet_name='凭证')

I ran the code above but when I open the file I found the sheet name is 'pyexcel_sheet1'

@chfw

This comment has been minimized.

Member

chfw commented Mar 23, 2018

Just had a look, it is true that sheet_name is not passed on. let me think about the parameters.

At the moment , class Sheet accepts name to set sheet name. sheet_name is felt more informative.

@chfw chfw added the enhancement label Mar 23, 2018

@chfw chfw closed this in bc7c86b Mar 23, 2018

@chfw

This comment has been minimized.

Member

chfw commented Mar 23, 2018

pip install https://github.com/pyexcel/pyexcel/archive/master.zip will get you the enhancement.

chfw added a commit that referenced this issue Mar 26, 2018

chfw added a commit that referenced this issue Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment