Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional test dependency on pyexcel-handsontable #169

Closed
jayvdb opened this issue Feb 8, 2019 · 1 comment
Closed

Optional test dependency on pyexcel-handsontable #169

jayvdb opened this issue Feb 8, 2019 · 1 comment

Comments

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 8, 2019

The tests state they depend on pyexcel-handsontable, but that depends on @pyecharts , has problem pyexcel-renderers/pyexcel-handsontable#5 , but generally is less mature than pyexcel.

The test suite should at least skip the relevant tests when pyexcel-handsontable is not installed, so that the packagers dont need to get @pyecharts working before they can get @pyexcel packaged with tests passing.

@chfw
Copy link
Member

@chfw chfw commented Feb 14, 2019

Let me have a look. I may have winded myself up.

@chfw chfw mentioned this issue Feb 21, 2019
@chfw chfw closed this in 356cd7c Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants