New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_to_memory function #68

Closed
shanyj opened this Issue Dec 23, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@shanyj

shanyj commented Dec 23, 2016

hi~
I notice that in pyexcel==0.2.5, save_to_memory function in pyexcel.book.py and pyexcel.sheets.sheet return a StringIo type, However in pyexcel==0.4.0, it returns a str type which make seek() func in my project throw a error.
I am curious about why use str instead of StringIo type?~

Regards
Yj

@chfw

This comment has been minimized.

Member

chfw commented Dec 23, 2016

I am sorry for this surprise. Its implementation was changed without actual specific requirements. I would take this as a regression and restore its functionality. Stay tuned.

@chfw chfw added the bug label Dec 23, 2016

@chfw chfw closed this in 476a2d2 Dec 23, 2016

@chfw

This comment has been minimized.

Member

chfw commented Dec 23, 2016

Please have a go on it before I release it to pypi .

@shanyj

This comment has been minimized.

shanyj commented Dec 28, 2016

thx~

@chfw chfw reopened this Feb 6, 2017

@chfw

This comment has been minimized.

Member

chfw commented Feb 6, 2017

It was found that the stream should have been sought at 0 before returning.

reference: pyexcel-webwares/django-excel#33

@chfw chfw closed this in 3de36ca Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment