Projection of Oneiros with Remote Tracking Computer does not include the ship's bonus

[sdack]

Hello,

I've been trying to figure out the effect of the Oneiros' remote tracking computers onto a turret ship like the Kronos and the Vindicator. I believe the Oneiros' ship bonus (to the effectiveness of remote tracking computers) does not get applied in the projection.

How I have tested it: I've created a fit for the Oneiros with a single remote tracking computer and all skills 5 and pulled it into the "Projected" tab of a Kronos. I did the same with a single remote tracking computer out of the market group (the same one as on the Oneiros). When I toggle the projected effect do both projections show an increase in range (both use an optimal range script), but the increased ranges are the same. Due to the bonus should the Oneiros give a higher increased range compared to an unbonused ship.

Could you please check if that is indeed a bug?

Pyfa version is: 1.15.0

[blitzmann]

I cannot reproduce. I have a retribution with small lasers, with base tracking of 0.155. If I add a remote tracking computer II with a tracking script, it adds 30% with a resultant of 0.201. If I add an oneiros with the same module and same charge (only thing on the fit), it gives me a 45% boost to 0.224. So the Oneiros is giving the proper stats according to my testing. All fits tested are set to All 5 character.

If you still can't get it to display the correct value, double check things like implants, fleet boosters, and skills/character. It could very well be a problem with the order the modules are run as we have had issues with that before, but usually for very edge-case scenarios. If you can, I would like you to post the fits that you are using along with screenshots if possible of module order from both fits.

Thanks =)

[sdack]

Hello,
I have done what you did and I can confirm that it does indeed work for the Retribution. However, I seem to have found a case where it does not. I have created a clean test case:

• Oneiros, with only a single Remote Tracking Computer II (Optimal Range script)
• Kronos, with a single Neutron Blaster Cannon II

When both fits are set to "All 5" then the range on the blaster changes to:

• RTC II w/ OR script: 9km+18.8km -> 10.3km+24.4km,
• Oneiros: 9km+18.8km -> 11km+27.2km

So there it is working. When I set Kronos fitting from "All 5" to my character then this happens:

• RTC II w/ OR script: 9km+18.8km -> 10.3km+24.4km
• Oneiros: 9km+18.8km -> 10.3km+24.4km

Here it is not working. Now, I can fly the Kronos, but I cannot fly the Oneiros, which is why I left the Oneiros fit to "All 5". Is it possible that it tries to apply my character's skills to the Oneiros fit for the projection, too? This is the only reasonable explanation that I have for it not applying the Oneiros' bonus.

Cheers

(edited by blitzmann: formatting)

[blitzmann]

Can you please e-mail api details for the character you are having a problem with? Please only include skill access for the api.

sable.blitzmann@gmail.com

[blitzmann]

Actually, I have reproduced the issue using All 0, and it is very weird. A quick debug statement in the fit calculation logic shows that the Kronos is being calculated with the All 0 character, while the Onerios is being calculated with the All 5 character.

Looking at the stats of the RTC on the Onerios with All 5 shows that it should be giving 22.5% boost to optimal range and 45% boost to Falloff, but when it's applied to the Kronos it's only 15% and 30% respectively.

It might be possible that the ship bonuses aren't being applied before the module is projected...

Have you noticed anything like this in previous versions?

[blitzmann]

I made a new character with All 0 and set Logistics to lvl 3 and applied it to the Kronos, which boosted the Oneiros projection correctly. So it does seem that the projections are taking the target fit's character for whatever reason. It doesn't make sense to me, but it seems you were correct. =)

I'll take a look at it in the coming days

[blitzmann]

I think I found out what was happening. The target fit was being registered as the RTC II's fit in it's modified attributes, and when trying to modify the attribute based on the logistics skill, it used the wrong fit's character. Should be fixed, but I'm going to make a pre-release soonish due to this change and another that affect fit calculations. I want more scenarios tested

[sdack]

Thanks, it is much appreciated. I have downloaded 1.15.1 from GitHub and tested
it - it works for me :)

On 05/10/15 23:22, blitzmann wrote:

I think I found out what was happening. The target fit was being registered as
the RTC II's fit in it's modified attributes, and when trying to modify the
attribute based on the logistics skill, it used the wrong fit's character.
Should be fixed, but I'm going to make a pre-release soonish due to this
change and another that affect fit calculations. I want more scenarios tested

—
Reply to this email directly or view it on GitHub
#374 (comment).

[blitzmann]

Sweet, will close this for now. If I find issues in the fixes, I'll revert and reopen.