Skip to content

Add a simple usage note to projected view#382

Merged
blitzmann merged 4 commits into
pyfa-org:masterfrom
Will-W:master
Oct 14, 2015
Merged

Add a simple usage note to projected view#382
blitzmann merged 4 commits into
pyfa-org:masterfrom
Will-W:master

Conversation

@Will-W
Copy link
Copy Markdown
Contributor

@Will-W Will-W commented Oct 13, 2015

Had a few people in corp not realise you could put a whole ship fitting in the 'Projected' view. Thought a basic usage hint might help.

cropped_screenshot

Will Wykeham added 4 commits October 13, 2015 15:56
On GTK, the handler will get called twice if you call skip(),
and a ValueError exception is thrown on cmdline
We're handling the event so skip not necessary.
@Will-W
Copy link
Copy Markdown
Contributor Author

Will-W commented Oct 13, 2015

Tested on Linux - wxGTK 2.8, and on Windows, both 2.8 and 3.0.

Happy to add similar notes to the other tabs for consistency if you want, but they're more obvious (except fleet which already has a note).

@blitzmann
Copy link
Copy Markdown
Collaborator

I have been wanting to do this ever since I added that note to the fleet thing, the only thing stopping me was the fact that the other views used the Display while the fleet views straight up used it's own panel.

I can't check the code right now, but it seems like you insert the message into the Name column, yeah? I think a better solution would be to append the message to the bottom of the Display class, but it would take more work because you'll have to make a new panel and add the Display along with the message (in theory).

This looks like a good first step tho and I'll be happy to merge it once I have a chance to take a look. =)

blitzmann added a commit that referenced this pull request Oct 14, 2015
Add a simple usage note to projected view
@blitzmann blitzmann merged commit 1415de9 into pyfa-org:master Oct 14, 2015
@Will-W
Copy link
Copy Markdown
Contributor Author

Will-W commented Oct 14, 2015

I had a little think about the best way of doing this. Started just with tooltip but decided it wasn't obvious enough.

The nice thing about this approach is that it's really obvious without consuming any screen real-estate. It's also a metaphor that users will be familiar with: "drag thing to here".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants