Skip to content

add python 3.14 to ci and metadata#853

Merged
mberz merged 2 commits intomainfrom
enh/python-314
Nov 14, 2025
Merged

add python 3.14 to ci and metadata#853
mberz merged 2 commits intomainfrom
enh/python-314

Conversation

@ahms5
Copy link
Copy Markdown
Member

@ahms5 ahms5 commented Nov 6, 2025

Changes proposed in this pull request:

  • add python 3.14 to ci
  • add python 3.13 and 3.14 to package metadata

@ahms5 ahms5 self-assigned this Nov 6, 2025
@ahms5 ahms5 added this to the v0.7.4 milestone Nov 6, 2025
@ahms5 ahms5 added the ci Related to continuous integration and Travis label Nov 6, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Python 3.14 to the project by updating the package classifiers and CI/CD configuration.

  • Added Python 3.14 classifier to pyproject.toml
  • Added Python 3.14 to CI test matrices across both test workflows
  • Updated deprecation warning tests to run on Python 3.14 instead of 3.13

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Added Python 3.13 and 3.14 classifiers to declare version support
.circleci/config.yml Added Python 3.14 to test matrices and updated deprecation warning test version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@f-brinkmann f-brinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! Looks good but the build test is failing. Not sure if its related to adding 3.14. Should probably be fixed elsewhere.

@hoyer-a
Copy link
Copy Markdown
Member

hoyer-a commented Nov 7, 2025

So what seems to have happened here is that with python 3.14 the default error message for list.index() has changed.

3.13
ValueError: 'bla' is not in list

3.14
ValueError: list.index(x): x not in list

The actual problem is that there is no specific error message from pyfar if a wrong unit is entered in group_delay_2d. I opened an issue for that: #854

Copy link
Copy Markdown
Member

@hoyer-a hoyer-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahms5 ahms5 mentioned this pull request Nov 10, 2025
@ahms5 ahms5 requested review from a team and mberz November 13, 2025 16:25
@mberz
Copy link
Copy Markdown
Member

mberz commented Nov 13, 2025

Please do not use git merge anymore, rather rebase your changes onto develop ;)

@mberz mberz merged commit b4ee8c2 into main Nov 14, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Weekly Planning Nov 14, 2025
@mberz mberz deleted the enh/python-314 branch November 14, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to continuous integration and Travis

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants