Removed test failing only on specific devices only#862
Merged
Conversation
…ers perform better overall and adapt comments
jf-som
changed the title
f-brinkmann
reviewed
Nov 12, 2025
Comment on lines
126
to
127
| near the nyquist frequency. Doing so sometimes leads to better results | ||
| for typical sampling rates, but much worse for very high rates. |
Member
There was a problem hiding this comment.
'Sometimes' sounds a little pessimistic and vague. How about being more specific, e.g.:
Suggested change
| near the nyquist frequency. Doing so sometimes leads to better results | |
| for typical sampling rates, but much worse for very high rates. | |
| near the nyquist frequency. Note that the parameters may depend on the sampling | |
| rate and operating systems. |
Contributor
Author
There was a problem hiding this comment.
Perhaps "results" would be more fitting than "parameters". I gave it a new try.
f-brinkmann
approved these changes
Nov 13, 2025
Member
|
Please do not use PRs to discuss feature planning beyond the scope of the PR. |
Contributor
Author
If you mean the automated multi-OS testing, I was going to open a new issue but wanted to ask if this was already solved and I just didn't know ^^ |
mberz
approved these changes
Nov 13, 2025
Member
mberz
left a comment
mberz
left a comment
There was a problem hiding this comment.
Spotted a small typo. Approved ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
None
Changes proposed in this pull request:
As @f-brinkmann noticed, the function
test_frequency_weighting_filter_errwgt_recommendedintest_frequency_weighting.pyfails on his MacOS device, but not on my Windows device or on circleCI.Apparently, the scipy least-squares optimization can be platform/hardware-specific. I removed the failing assert, since it was only for a recommended function argument, and adjusted the recommendation in the docstring comment accordingly.
Moved to a new issue: