Skip to content

Conversation

@ahms5
Copy link
Member

@ahms5 ahms5 commented Oct 27, 2025

@ahms5 ahms5 self-assigned this Oct 27, 2025
@ahms5 ahms5 added this to the v0.4.2 milestone Oct 27, 2025
@ahms5 ahms5 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 27, 2025
@@ -0,0 +1,5 @@
blank_issues_enabled: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this is required for creatung subissues?

@ahms5 ahms5 requested review from Copilot, mberz and sikersten October 27, 2025 13:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the issue reporting workflow by replacing the old markdown-based issue template with structured YAML templates from pyOpenSci's package template. The update provides specific forms for different issue types (bugs, questions, feature requests) with guided input fields.

Key changes:

  • Added structured YAML templates for bug reports, questions, and feature requests with required checklists and validation
  • Configured community support links directing users to GitHub Discussions
  • Enhanced bug report template to include depinfo installation instructions for better environment reporting

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/ISSUE_TEMPLATE.md Removed the old generic markdown issue template
.github/ISSUE_TEMPLATE/config.yml Added configuration enabling blank issues and directing questions to discussions
.github/ISSUE_TEMPLATE/01-bug-report.yml Added structured bug report form with environment details and code sample fields
.github/ISSUE_TEMPLATE/02-question.yml Added question template with checklist to verify documentation/search attempts
.github/ISSUE_TEMPLATE/03-feature-request.yml Added feature request form with problem/solution/alternatives structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ahms5 ahms5 changed the title Add issue templates Revise issue templates Oct 27, 2025
Copy link
Member

@sikersten sikersten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!

attributes:
label: Environment
description: >
Please paste the output of running `depinfo --markdown pyrato`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested depinfo with pyfar an get some "missing" statements. Could it be that depinfo uses the dev requirements as checklist?

pytest-cov               missing
ruff                       0.6.3
scipy                     1.11.3
setuptools                68.0.0
sofar                      1.1.1
soundfile                 0.12.1
sphinx                   missing
sphinx-design            missing
sphinx-favicon           missing
sphinx-mdinclude         missing
sphinx-reredirects       missing
twine                    missing
urllib3                    2.1.0
watchdog                 missing
wheel                     0.41.2

Build Tools Information
-----------------------
pip          23.3
setuptools 68.0.0
wheel      0.41.2

Platform Information
--------------------
Windows 10-AMD64
CPython   3.11.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to find some documentation on that, but it does not seem that the project provides any apart from the README on GitHub

description: >
Please paste the output of running `depinfo --markdown pyrato`
in your environment between the `details` tags below.
If you have not installed `depinfo`, you can install it via `pip install depinfo`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add depinfo to the requirements?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems that the package is no longer maintained. The last officially supported python version is 3.11. Not sure if we want to have something like that as dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about using sth like pip list --local instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or pipdeptree instead
pipdeptree --package pyfar
this seems to be maintained

pyfar==0.7.3
├── numpy [required: >=1.23.0, installed: 2.3.3]
├── scipy [required: >=1.5.0, installed: 1.16.2]
│   └── numpy [required: >=1.25.2,<2.6, installed: 2.3.3]
├── matplotlib [required: Any, installed: 3.10.6]
│   ├── contourpy [required: >=1.0.1, installed: 1.3.3]
│   │   └── numpy [required: >=1.25, installed: 2.3.3]
│   ├── cycler [required: >=0.10, installed: 0.12.1]
│   ├── fonttools [required: >=4.22.0, installed: 4.60.1]
│   ├── kiwisolver [required: >=1.3.1, installed: 1.4.9]
│   ├── numpy [required: >=1.23, installed: 2.3.3]
│   ├── packaging [required: >=20.0, installed: 25.0]
│   ├── pillow [required: >=8, installed: 11.3.0]
│   ├── pyparsing [required: >=2.3.1, installed: 3.2.5]
│   └── python-dateutil [required: >=2.7, installed: 2.9.0.post0]
│       └── six [required: >=1.5, installed: 1.17.0]
├── sofar [required: >=0.1.2, installed: 1.2.2]
│   ├── netCDF4 [required: Any, installed: 1.7.2]
│   │   ├── cftime [required: Any, installed: 1.6.4.post1]
│   │   │   └── numpy [required: >=1.26.0b1, installed: 2.3.3]
│   │   ├── certifi [required: Any, installed: 2025.10.5]
│   │   └── numpy [required: Any, installed: 2.3.3]
│   ├── numpy [required: >=1.14.0, installed: 2.3.3]
│   ├── beautifulsoup4 [required: Any, installed: 4.14.2]
│   │   ├── soupsieve [required: >1.2, installed: 2.8]
│   │   └── typing_extensions [required: >=4.0.0, installed: 4.15.0]
│   ├── requests [required: Any, installed: 2.32.5]
│   │   ├── charset-normalizer [required: >=2,<4, installed: 3.4.3]
│   │   ├── idna [required: >=2.5,<4, installed: 3.10]
│   │   ├── urllib3 [required: >=1.21.1,<3, installed: 2.5.0]
│   │   └── certifi [required: >=2017.4.17, installed: 2025.10.5]
│   └── packaging [required: Any, installed: 25.0]
├── urllib3 [required: Any, installed: 2.5.0]
├── deepdiff [required: Any, installed: 8.6.1]
│   └── orderly-set [required: >=5.4.1,<6, installed: 5.5.0]
└── soundfile [required: >=0.11.0, installed: 0.13.1]
    ├── cffi [required: >=1.0, installed: 2.0.0]
    │   └── pycparser [required: Any, installed: 2.23]
    └── numpy [required: Any, installed: 2.3.3]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how the package works? Does it only resolve packages and dependencies installed via pip?
The name suggests that it does at least.

Copy link
Member Author

@ahms5 ahms5 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good qestion, its dependency is pip and package, so i think it used pip.
I tried it with uv uv run pipdeptree --package pyfar and it is working.
in the venv it is also working with source .venv/bin/activate && pipdeptree --package pyfar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked if it lists packages which were not installed through pip? (conda for example)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have just tested it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Then let's keep it!

Comment on lines +55 to +62
<details>

```text
Paste output of `pipdeptree --package pyrato` here

```

</details>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have adapted this, in this way to output would look like this:

Details
pyrato==0.4.1
├── pyfar [required: >=0.5.0, installed: 0.7.3]
│   ├── numpy [required: >=1.23.0, installed: 2.3.3]
│   ├── scipy [required: >=1.5.0, installed: 1.16.2]
│   │   └── numpy [required: >=1.25.2,<2.6, installed: 2.3.3]
│   ├── matplotlib [required: Any, installed: 3.10.6]
│   │   ├── contourpy [required: >=1.0.1, installed: 1.3.3]
│   │   │   └── numpy [required: >=1.25, installed: 2.3.3]
│   │   ├── cycler [required: >=0.10, installed: 0.12.1]
│   │   ├── fonttools [required: >=4.22.0, installed: 4.59.2]
│   │   ├── kiwisolver [required: >=1.3.1, installed: 1.4.9]
│   │   ├── numpy [required: >=1.23, installed: 2.3.3]
│   │   ├── packaging [required: >=20.0, installed: 25.0]
│   │   ├── pillow [required: >=8, installed: 11.3.0]
│   │   ├── pyparsing [required: >=2.3.1, installed: 3.2.4]
│   │   └── python-dateutil [required: >=2.7, installed: 2.9.0.post0]
│   │       └── six [required: >=1.5, installed: 1.17.0]
│   ├── sofar [required: >=0.1.2, installed: 1.2.2]
│   │   ├── netCDF4 [required: Any, installed: 1.7.2]
│   │   │   ├── cftime [required: Any, installed: 1.6.4.post1]
│   │   │   │   └── numpy [required: >=1.26.0b1, installed: 2.3.3]
│   │   │   ├── certifi [required: Any, installed: 2025.8.3]
│   │   │   └── numpy [required: Any, installed: 2.3.3]
│   │   ├── numpy [required: >=1.14.0, installed: 2.3.3]
│   │   ├── beautifulsoup4 [required: Any, installed: 4.13.5]
│   │   │   ├── soupsieve [required: >1.2, installed: 2.8]
│   │   │   └── typing_extensions [required: >=4.0.0, installed: 4.15.0]
│   │   ├── requests [required: Any, installed: 2.32.5]
│   │   │   ├── charset-normalizer [required: >=2,<4, installed: 3.4.3]
│   │   │   ├── idna [required: >=2.5,<4, installed: 3.10]
│   │   │   ├── urllib3 [required: >=1.21.1,<3, installed: 2.5.0]
│   │   │   └── certifi [required: >=2017.4.17, installed: 2025.8.3]
│   │   └── packaging [required: Any, installed: 25.0]
│   ├── urllib3 [required: Any, installed: 2.5.0]
│   ├── deepdiff [required: Any, installed: 8.6.1]
│   │   └── orderly-set [required: >=5.4.1,<6, installed: 5.5.0]
│   └── soundfile [required: >=0.11.0, installed: 0.13.1]
│       ├── cffi [required: >=1.0, installed: 2.0.0]
│       │   └── pycparser [required: Any, installed: 2.23]
│       └── numpy [required: Any, installed: 2.3.3]
├── numpy [required: >=1.14.0, installed: 2.3.3]
├── scipy [required: >=1.5.0, installed: 1.16.2]
│   └── numpy [required: >=1.25.2,<2.6, installed: 2.3.3]
└── matplotlib [required: Any, installed: 3.10.6]
    ├── contourpy [required: >=1.0.1, installed: 1.3.3]
    │   └── numpy [required: >=1.25, installed: 2.3.3]
    ├── cycler [required: >=0.10, installed: 0.12.1]
    ├── fonttools [required: >=4.22.0, installed: 4.59.2]
    ├── kiwisolver [required: >=1.3.1, installed: 1.4.9]
    ├── numpy [required: >=1.23, installed: 2.3.3]
    ├── packaging [required: >=20.0, installed: 25.0]
    ├── pillow [required: >=8, installed: 11.3.0]
    ├── pyparsing [required: >=2.3.1, installed: 3.2.4]
    └── python-dateutil [required: >=2.7, installed: 2.9.0.post0]
        └── six [required: >=1.5, installed: 1.17.0]

@ahms5 ahms5 requested a review from sikersten October 30, 2025 08:42
@ahms5
Copy link
Member Author

ahms5 commented Oct 30, 2025

added tempalte for documentation issues based in the numpy tempalte

Copy link
Member

@sikersten sikersten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we align the placeholders?

@@ -0,0 +1,49 @@
name: Feature request
description: Suggest an idea for this project
title: "[ENH] "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with DOC?

Suggested change
title: "[ENH] "
title: "[ENH] <Please write a comprehensive title after the 'ENH: ' prefix>"

@@ -0,0 +1,27 @@
name: Question
description: Ask a question
title: "[Question] "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with DOC?

Suggested change
title: "[Question] "
title: "[Question] <Please write a comprehensive title after the 'Question: ' prefix>"

@@ -0,0 +1,74 @@
name: 🐞 Bug report
description: Report a problem to help improve this project
title: "[BUG] "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with DOC?

Suggested change
title: "[BUG] "
title: "[BUG] <Please write a comprehensive title after the 'BUG: ' prefix>"

@ahms5 ahms5 requested a review from sikersten October 30, 2025 12:16
@@ -0,0 +1,74 @@
name: 🐞 Bug report
description: Report a problem to help improve this project
title: "[BUG] <Please write a comprehensive title after the '[BUG] ' prefix>"
Copy link
Member

@sikersten sikersten Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I understand is, the title will then be "[BUG] Title of the issue". Is this intended? Numpy style would be "BUG: Title of the issue". I'm fine with both.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but @mberz started this style, https://github.com/pyfar/pyrato/issues
both would work for me

@mberz mberz merged commit 3fb1352 into main Oct 31, 2025
12 checks passed
@mberz mberz deleted the issue_templates branch October 31, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants