Add GitHub Actions to check if a PR has a label and a milestone#41
Add GitHub Actions to check if a PR has a label and a milestone#41
Conversation
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
nice thanks, just fixed a bug in the current implmentation
| - labeled | ||
| - unlabeled |
There was a problem hiding this comment.
| - labeled | |
| - unlabeled | |
| - milestoned | |
| - demilestoned |
ok thanks a bugfix from the current version. this will retrigger the workflow if we change the milestone instead of the label. See https://docs.github.com/de/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
There was a problem hiding this comment.
Oh, I just realized that I made this change in the file template-pyfar-package/.github/workflows/has_version_milestone.yml and not in the file template-pyfar-package/template/.github/workflows/has_version_milestone.yml. I’ll remove this change from the wrong file.
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
almost done, it is just missing at an other position, toherwise approved
| - labeled | ||
| - unlabeled |
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
2 participants
Which issue(s) are closed by this pull request?
Closes #27
Changes proposed in this pull request:
.github/workflows/has_label.htmland.github/workflows/has_version_milestone.html. They were copied unchanged from the pyfar repository.test_generated_file_exists()to include parameterization with new files.