Add scatter_max#653
Merged
Merged
Conversation
akihironitta
force-pushed
the
port/scatter-04-min
branch
from
0b028d9 to
fbac654
Compare
Symmetric to `scatter_min`: init `out` to `numeric_limits::lowest()`, strict `>` comparison, `atomicMax` value pass on CUDA. The argindex pass is byte-identical to min (still `atomicMin` on argindex for deterministic first-match on ties). Backward is the same `+1`/`narrow` pattern.
akihironitta
force-pushed
the
port/scatter-05-max
branch
from
52ad05f to
a44d219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symmetric to
scatter_min: initouttonumeric_limits::lowest(),strict
>comparison,atomicMaxvalue pass on CUDA. The argindex passis byte-identical to min (still
atomicMinon argindex for deterministicfirst-match on ties). Backward is the same
+1/narrowpattern.