Polygon as_segments()
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
reviewed
Jan 11, 2023
itzpr3d4t0r
reviewed
Jan 11, 2023
itzpr3d4t0r
reviewed
Jan 11, 2023
itzpr3d4t0r
reviewed
Jan 12, 2023
itzpr3d4t0r
reviewed
Jan 12, 2023
Comment on lines
+452
to
+477
| def test_as_segments(self): | ||
| """Checks whether polygon segments are correct""" | ||
| poly = Polygon([(0, 0), (1, 0), (1, 1), (0, 1)]) | ||
| self.assertEqual( | ||
| poly.as_segments(), | ||
| [ | ||
| Line((0, 0), (1, 0)), | ||
| Line((1, 0), (1, 1)), | ||
| Line((1, 1), (0, 1)), | ||
| Line((0, 1), (0, 0)), | ||
| ], | ||
| ) | ||
| poly = Polygon([(123.23, 35.6), (56.4, 87.45), (43.1, 12.3)]) | ||
| self.assertEqual( | ||
| poly.as_segments(), | ||
| [ | ||
| Line((123.23, 35.6), (56.4, 87.45)), | ||
| Line((56.4, 87.45), (43.1, 12.3)), | ||
| Line((43.1, 12.3), (123.23, 35.6)), | ||
| ], | ||
| ) | ||
| poly = Polygon([[1, 2], [3, 4], [5, 6]]) | ||
| self.assertEqual( | ||
| poly.as_segments(), | ||
| [Line((1, 2), (3, 4)), Line((3, 4), (5, 6)), Line((5, 6), (1, 2))], | ||
| ) |
Member
There was a problem hiding this comment.
You should add more tests for invalid argument types and argument number.
Member
There was a problem hiding this comment.
Basically you should make sure that this is actually a no arguments method now and in the future
Member
|
I would be thankful if you could add a couple benchmarks as well in the benchmarks directory, though that's not strictly necessary, i can add them later. |
itzpr3d4t0r
reviewed
Jan 13, 2023
Comment on lines
210
to
+211
| @overload | ||
| def as_segments(self) -> List[Line]: ... |
Member
There was a problem hiding this comment.
you don't need @overload here, there's just one way to call this function
itzpr3d4t0r
added
type:new_api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155