created SIMD version of line-rect intersection #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
added
type:performance
Starbuck5
reviewed
Aug 10, 2022
|
|
||
| extensions = [Extension("geometry", sources=["src_c/geometry.c"])] | ||
|
|
||
| compiler_options = {"unix": ["-mavx2"], "msvc": ["/arch:AVX2"]} |
Member
There was a problem hiding this comment.
This is not necessary. Since you're using intrinsics, the compiler isn't emitting the symbols, you are. With these options, the project will not run at all on older systems, I believe.
Starbuck5
reviewed
Aug 10, 2022
src_c/collisions.c
Outdated
| double *T) | ||
| { | ||
| #ifdef __AVX2__ | ||
| return pgIntersection_LineRect_avx2(line, rect, X, Y, T); |
Member
There was a problem hiding this comment.
This needs a runtime check as well.
itzpr3d4t0r
reviewed
Aug 10, 2022
itzpr3d4t0r
reviewed
Aug 10, 2022
itzpr3d4t0r
reviewed
Aug 10, 2022
itzpr3d4t0r
reviewed
Aug 11, 2022
itzpr3d4t0r
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this version is about 3 times faster than the normal path