Fix asyncadapter.Event #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
commented
Dec 18, 2025
Comment on lines
42
to
+49
| async def wait(self): | ||
| if self._is_set: | ||
| return | ||
| pass | ||
| else: | ||
| return self # triggers __await__ | ||
| await self # triggers __await__ | ||
|
|
||
| def __await__(self): | ||
| return {"wait_method": "event", "event": self} | ||
| yield {"wait_method": "event", "event": self} |
Contributor
😆 |
Member
Author
|
You know when you think a piece of work is just going to take a few hours, and it turns out to take much longer? I have that a lot, but the recent async work was probably the worst case I experienced ... |
Contributor
I'd bet it'd make for a fun blog post! I totally understand, it's oh so relatable ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug
There is a bug in the asyncadapter's
Eventobject;await event.wait()returns immediately. This event object is only really used inawait sleep()whenUSE_THREADED_TIMERis set, which is default on Windows.The consequence is that it breaks the scheduling when on Windows and using the
asyncadapter(using Qt, Wx, or Raw loop).I apologize for those affected; this should not have happened. I did run with
USE_THREADED_TIMER, but apparently only in combination with asyncio. I should have run tests on Windows, or better yet, run Windows-tests on CI, but I was too eager to move forward, because this async stuff was taking sooo long ...The solution
Ref pyapp-kit/scenex#42 (comment)