Fix several warnings in tests #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests that I ran earlier on Windows, there were quite a few warnings from the
CallLaterThread. When the loop closes when a normalawait sleep(..)is waiting, the task is simply cancelled at its done. But with a sleep that runs via theCallLaterThread, the thread will try to invoke a callback in the main thread via the loop, which is now closed, which gives a warning.In #162 this effect was already reduced by confining the use of
precise_sleepto the scheduler. This PR explicitly suppresses such warnings, since they can in occur in normal operation closely after a loop is closed.While investigating this, I came across some more warnings due to asyncio loops not being closed in the tests. I fixes these too.