Make canvas arg in request_adapter() optional #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
canvasargument inrequest_adapter()is not part of the WebGPU spec. It is an optional argument towgpuInstanceRequestAdapter(), so it seemed like a good idea to make it possible to pass this argument. I initially made it a required argument, but in practice it is often set to None, because we often want to create a (global) device before we have a canvas.Changes
This PR makes the argument optional, and puts it to the end of the arg to move it a bit out of sight, making the API feel more like WebGPU.
I want to get this into the 0.12.0 release, because our users will have to adjust their
request_adapter()calls already.