Fix that memory for struct data was released before wgpu-native consumed it #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
approved these changes
Nov 5, 2025
Contributor
|
Thanks. Confirmed this actually does fix things on my machine. I ran it on the previous commit and it would crash 5/5 with a segfault. And with this it would pass 5/5 |
Contributor
|
its funny, i had pushed my hack, now i'm backporting this, thx. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763 (very probably)
I checked every case of
ffi.cast(), and refactored each instance where we usenextInChainto use the same pattern.The actual problem in #763 is fixed by letting the function
_create_render_pipeline_descriptor()also return a list of objects, so that their lifetime is bound to the scope of the caller instead of the scope of the function.