Enhance Postgres database facts and operations #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wowi42
commented
Mar 24, 2025
wowi42
commented
- Updated the SQL command in PostgresDatabases to include the database owner.
- Modified the database operation to handle owner updates and added logic for skipping existing databases with specific attributes.
- Added a new test case for updating database ownership in the operations tests.
- Updated the SQL command in PostgresDatabases to include the database owner. - Modified the database operation to handle owner updates and added logic for skipping existing databases with specific attributes. - Added a new test case for updating database ownership in the operations tests.
…ation logic - Updated SQL command formatting in PostgresDatabases for better readability. - Simplified string formatting in the database operation to enhance clarity and maintainability.
- Implemented a check to prevent re-creation of databases with the same parameters, enhancing idempotency in the database operation. - Added a noop message to inform users when a database already exists with the specified attributes.
- Added checks to ensure the tablespace is only altered if it differs from the current configuration, improving the idempotency of the database operation. - Updated the conditional logic for setting the tablespace to enhance clarity and maintainability.
- Added a new 'tablespace' parameter to the database update JSON configuration. - Updated the SQL command to set the tablespace along with the database owner, enhancing the database operation's functionality.
Fizzadar
approved these changes
Mar 27, 2025
Fizzadar
pushed a commit
that referenced
this pull request
Mar 27, 2025
Fizzadar
pushed a commit
that referenced
this pull request
Mar 27, 2025
Fizzadar
pushed a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.