Skip to content

Conversation

@goetzk
Copy link
Contributor

@goetzk goetzk commented Mar 27, 2025

Methods are used at different times to affect the configuration process; this tries to explain which methods can be used and when they will be run.

Methods are used at different times to affect the configuration process;
this tries to explain which methods can be used and when they will be
run.
@goetzk goetzk mentioned this pull request Mar 29, 2025
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement, thank you @goetzk!

```
`make_names_data` is used to supply inventory data about a host while at 'Loading inventory' stage.

Its worth being aware up front that due to `make_names_data` being a `staticmethod` it has no automatic access to the parent classes attributes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an annoying decision I made that I'd like to change 🙃

@Fizzadar Fizzadar merged commit 83e3805 into pyinfra-dev:3.x Apr 7, 2025
4 of 6 checks passed
@goetzk goetzk deleted the where-to-change-connectors branch April 9, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants