Skip to content

Prevent UnicodeErrors when forwarding child stdout to the console #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisAichinger wants to merge 2 commits into from
Closed

Prevent UnicodeErrors when forwarding child stdout to the console #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c6e215
Prevent UnicodeErrors when forwarding child stdout
ChrisAichinger May 3, 2015
741f3c9
Don't rely on sys.stdout.buffer being available
ChrisAichinger May 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion invoke/runners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@ def get():
yield data
for data in codecs.iterdecode(get(), encoding, errors='replace'):
if not hide:
dst.write(data)
# Make sure no UnicodeError happens, even if the data is
# garbled (e.g. due to encoding mismatch with the child).
encoded_data = data.encode(dst.encoding, errors='replace')
clean_data = encoded_data.decode(dst.encoding)
dst.write(clean_data)
dst.flush()
cap.append(data)

Expand Down