Worked around a Python 2.6 bug whereby file streams don't respect encoding#262
Closed
fgimian wants to merge 1 commit intopyinvoke:masterfrom
fgimian:python-2.6-encoding-bug
Closed
Worked around a Python 2.6 bug whereby file streams don't respect encoding#262fgimian wants to merge 1 commit intopyinvoke:masterfrom fgimian:python-2.6-encoding-bug
fgimian wants to merge 1 commit intopyinvoke:masterfrom
fgimian:python-2.6-encoding-bug
Conversation
Author
|
Oh dear, I broken Python 3.x compatibility. I'll look into a better way, bear with me. 😄 |
11 tasks
Member
|
This should be obviated by changes in #350 now. Please comment after the 0.13 release comes out if that doesn't fix things for you. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again 😄
After many hours of trying to find the best way to solve this problem, here's my solution. It ensures that Python 2.6 file streams will always encode to bytes before writing to the output stream. This works around Python issue 4947.
You may reproduce the original problem as follows with Python 2.6:
Then run:
Feel free to ask any questions and thanks for the amazing tool! 😄
Cheers
Fotis